larroy commented on issue #14095: Optimize move semantics of NodeEntry URL: https://github.com/apache/incubator-mxnet/pull/14095#issuecomment-494144633 Moving a shared pointer is faster than copying. When using move in the microbenchmark is 10% faster. Overall is not much and in the big picture won't make a difference, but these small inefficiencies compound together and make the code in general slower in a way that you can't profile as it's scatered all over. What changes exactly are you suggesting? to the title of the PR? is not clear to me, please help clarify. It can also cause contention between threads due to the atomic lock. ``` Note: Google Test filter = NodeTest* [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from NodeTestX [ RUN ] NodeTestX.NodeTest 1655650[ OK ] NodeTestX.NodeTest (1804 ms) [----------] 1 test from NodeTestX (1804 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (1804 ms total) [ PASSED ] 1 test. ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
