daveliepmann opened a new pull request #15023: Extend Clojure BERT example
URL: https://github.com/apache/incubator-mxnet/pull/15023
 
 
   ## Description ##
   This PR extends the BERT sentence pair example in Clojure to include testing 
of the fine-tuned model on individual sentence pair samples. I discussed this 
last week with @gigasquid [on 
Slack](https://the-asf.slack.com/archives/CEE9X9WN7/p1558103162000500).
   
   All the important changes are in the rich comment at the bottom of 
`bert_sentence_classification`, and are intended to be explored with a REPL. I 
plan to copy the REPL-driven example to the iPython notebook example after I'm 
sure my approach is correct but before merging.
   
   I think my approach is correct but would like to double-check the following 
before merging:
    - [ ] is there a way to pass the fine-tuned model directly to the `infer` 
API, rather than creating a factory over a saved checkpoint?
    - [ ] is my interpretation of results correct? I included some individual 
samples that surprised me.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - ~~[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)~~
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   ~~- [ ] All changes have test coverage:~~
   - [x] Code is well-documented: 
   - For new examples,  ~~README.md is~~ *inline comments are* added to explain 
the what the example does, the source of the dataset, expected performance on 
test set and reference to the original paper if applicable
   - [x] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
    - [ ] TODO copy the REPL-driven example to the iPython notebook
   
   ### Changes ###
   - [x] evaluate Clojure BERT sentence pair example with individual sentence 
pair samples
   
   ## Comments ##

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to