reminisce commented on a change in pull request #15007: Add matrix determinant
operator in linalg
URL: https://github.com/apache/incubator-mxnet/pull/15007#discussion_r286173193
##########
File path: src/operator/tensor/la_op.h
##########
@@ -413,6 +413,50 @@ inline bool InverseShape(const nnvm::NodeAttrs& attrs,
return true;
}
+// Shape inference function for det functions in linalg
+template<int onum>
+inline bool DetShape(const nnvm::NodeAttrs& attrs,
+ mxnet::ShapeVector* in_attrs,
+ mxnet::ShapeVector* out_attrs) {
+ CHECK_EQ(in_attrs->size(), 1);
+ CHECK_EQ(out_attrs->size(), onum + 2);
+ const mxnet::TShape& in = (*in_attrs)[0];
Review comment:
Please add this line of code here:
```cpp
if (!ndim_is_known(in)) return false;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
