larroy commented on a change in pull request #14900: Fix warning / static
function in header.
URL: https://github.com/apache/incubator-mxnet/pull/14900#discussion_r286359344
##########
File path: src/operator/nn/dropout.cc
##########
@@ -26,6 +26,32 @@
#include "./dropout-inl.h"
#include "../operator_common.h"
+#include "mxnet/op_attr_types.h"
+
+namespace {
+
+using namespace mxnet;
+using namespace mxnet::op;
Review comment:
Can you elaborate on your request? is local to that file so I think it
should be in the anonymous namespace. That would be the best practice in my
opinion since it's not exposed publicly in that namespace.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
