perdasilva commented on a change in pull request #15051: CD Framework + static 
binary release
URL: https://github.com/apache/incubator-mxnet/pull/15051#discussion_r286949636
 
 

 ##########
 File path: ci/Jenkinsfile_utils.groovy
 ##########
 @@ -18,14 +18,24 @@
 // under the License.
 
 // initialize source codes
-def init_git() {
+def init_git(git_sha = '') {
+
+  git_sha = git_sha ? git_sha.trim() : ''
 
 Review comment:
   On second thought. I have removed the MXNET_SHA. I will leave it in the 
artifact repository though. I would like to have the affordance of overriding 
the commit_id that gets pulled from the artifact repository. This will be 
useful when developing (so you don't need compile mxnet every time when 
developing the pipeline for a particular release channel).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to