apeforest commented on a change in pull request #15048: [MXNET-1408] Adding 
test to verify Large Tensor Support for ravel and unravel
URL: https://github.com/apache/incubator-mxnet/pull/15048#discussion_r287530059
 
 

 ##########
 File path: tests/nightly/test_large_array.py
 ##########
 @@ -279,6 +279,19 @@ def test_diag():
     assert_almost_equal(r.asnumpy(), np.diag(a_np, k=k))
 
 
+def test_ravel_and_unravel():
+    idxs_2d = [[LARGE_X-1,LARGE_X-100,6],[SMALL_Y-1,SMALL_Y-10,1]]
 
 Review comment:
   We can add C++ unit test to mock the memory allocation. However, I thought 
the nightly test is  used for end-to-end testing purpose to mimic the real 
deployment situation, or is it not? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to