reminisce opened a new pull request #15073: Restore save/load ndarray to 1.4.1 URL: https://github.com/apache/incubator-mxnet/pull/15073 ## Description ## This PR restores the `NDArray::Save/Load` functions to 1.4.1 for keeping backward compatibility for saving/loading zero-size tensors. The issue was reported in https://github.com/apache/incubator-mxnet/issues/14954#issuecomment-492867737 by @DickJC123. This PR depends on https://github.com/apache/incubator-mxnet/pull/15063. I will rebase this PR after https://github.com/apache/incubator-mxnet/pull/15063 is merged. @DickJC123 Since we are not going to have the NumPy shape semantics in the next release, I simply reverted the changes for serialization functions introduced by https://github.com/apache/incubator-mxnet/pull/14661. After careful thinking, I find that it's required to depend on the compatibility mode to save/load ndarrays in legacy/numpy shape semantics (we will also need a magic version number to guard this when loading). We will deal with it after introducing NumPy operators. Right now, I added `CHECK` in save/load functions indicating that numpy shape semantics cannot be turned on. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes) - [x] Changes are complete (i.e. I finished coding on this PR) - [x] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [ ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
