apeforest commented on a change in pull request #15059: [MXNET-1410]Adding Large Tensor Support for tensor transpose URL: https://github.com/apache/incubator-mxnet/pull/15059#discussion_r288705495
########## File path: tests/nightly/test_large_array.py ########## @@ -279,6 +279,33 @@ def test_diag(): assert_almost_equal(r.asnumpy(), np.diag(a_np, k=k)) +def create_large_tensor(): Review comment: can we make this method more generic, so user can pass in values to create tensors with different dimension? Also, if it is limited to a 2D tensor, maybe you want to rename the method too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services