apeforest commented on a change in pull request #15042: [MXNET-1405] tests for
large tensor support for Softmax operator
URL: https://github.com/apache/incubator-mxnet/pull/15042#discussion_r288706614
##########
File path: tests/nightly/test_large_array.py
##########
@@ -279,6 +272,13 @@ def test_diag():
assert_almost_equal(r.asnumpy(), np.diag(a_np, k=k))
+def test_softmax():
+ input_data = mx.nd.ones((SMALL_Y, LARGE_X))
+ true_output = np.full((SMALL_Y, LARGE_X), (1 / SMALL_Y))
+ output = nd.softmax(input_data, axis=0)
Review comment:
when you test this way, the softmax is operating only on one dimension which
does not exceed 2^32, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
