kshitij12345 commented on a change in pull request #14613: [MXNET-978] Higher
order gradient support for some unary operators
URL: https://github.com/apache/incubator-mxnet/pull/14613#discussion_r289488060
##########
File path: src/operator/tensor/elemwise_unary_op_trig.cc
##########
@@ -63,7 +82,27 @@ The storage type of ``cos`` output is always dense
)code" ADD_FILELINE)
.set_attr<nnvm::FGradient>("FGradient", ElemwiseGradUseIn{"_backward_cos"});
-MXNET_OPERATOR_REGISTER_BINARY_WITH_SPARSE_CPU(_backward_cos,
unary_bwd<mshadow_op::cos_grad>);
+MXNET_OPERATOR_REGISTER_BINARY_WITH_SPARSE_CPU(_backward_cos,
unary_bwd<mshadow_op::cos_grad>)
+.set_attr<nnvm::FGradient>("FGradient",
+ [](const nnvm::NodePtr& n, const std::vector<nnvm::NodeEntry>& ograds) {
+ // f(x) = cos(x)
+ // f'(x) = -sin(x)
+ // f''(x) = -cos(x)
+ auto grad_x = nnvm::NodeEntry{n};
+ auto grad_grad_x_mid = MakeNode("cos", n->attrs.name + "_mid_grad_grad",
+ {n->inputs[1]}, nullptr, &n);
+ auto grad_grad_x = MakeNode("negative", n->attrs.name +
"_backward_grad_grad",
+ {nnvm::NodeEntry(grad_grad_x_mid)}, nullptr,
&n);
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
