access2rohit commented on a change in pull request #15059: [MXNET-1410]Adding
Large Tensor Support for tensor transpose
URL: https://github.com/apache/incubator-mxnet/pull/15059#discussion_r289499335
##########
File path: tests/nightly/test_large_array.py
##########
@@ -279,6 +279,33 @@ def test_diag():
assert_almost_equal(r.asnumpy(), np.diag(a_np, k=k))
+def create_2d_tensor(rows, columns):
+ a = np.arange(0, rows).reshape(rows, 1)
+ b = np.broadcast_to(a, shape=(a.shape[0], columns))
+ return nd.array(b, dtype=np.int64)
Review comment:
adding conversion to same line makes it too long. I felt to keep that in
next line makes it more readable. Also, do you think adding return statement
makes it less pythonic ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
