apeforest commented on a change in pull request #15048: [MXNET-1408] Adding
test to verify Large Tensor Support for ravel and unravel
URL: https://github.com/apache/incubator-mxnet/pull/15048#discussion_r289562788
##########
File path: tests/nightly/test_large_array.py
##########
@@ -274,11 +265,40 @@ def test_diag():
assert_almost_equal(r.asnumpy(), np.diag(a_np, k=k))
# random k
- k = np.random.randint(-min(LARGE_X, 64) + 1, min(h, w))
+ k = np.random.randint(-min(LARGE_X, SMALL_Y) + 1, min(LARGE_X, SMALL_Y))
r = mx.nd.diag(a, k=k)
assert_almost_equal(r.asnumpy(), np.diag(a_np, k=k))
+def random_2d_coordinates(x_low, x_high, y_low, y_high):
Review comment:
I just realized there is existing utility that does what you want to achieve
here. Please use
https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/test_utils.py#L418
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
