szha commented on a change in pull request #15106: NER example: fix metrics computation URL: https://github.com/apache/incubator-mxnet/pull/15106#discussion_r289618653
########## File path: example/named_entity_recognition/src/ner.py ########## @@ -205,6 +209,8 @@ def sym_gen(seq_len): def train(train_iter, val_iter): import metrics devs = mx.cpu() if args.gpus is None or args.gpus is '' else [mx.gpu(int(i)) for i in args.gpus.split(',')] + logging.getLogger().info("train on device %s using optimizer %s at learningrate %f for %d epochs using %d records: lstm_state_size=%d ..." Review comment: ```suggestion logging.info("train on device %s using optimizer %s at learningrate %f for %d epochs using %d records: lstm_state_size=%d ...", devs, args.optimizer, args.lr, args.num_epochs, args.max_records, args.lstm_state_size) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services