zachgk commented on a change in pull request #15128: update LICENSE
URL: https://github.com/apache/incubator-mxnet/pull/15128#discussion_r290430818
##########
File path: tests/nightly/estimator/test_sentiment_rnn.py
##########
@@ -101,7 +101,19 @@ def download_imdb(data_dir='/tmp/data'):
'''
Download and extract the IMDB dataset
'''
- url = ('http://ai.stanford.edu/~amaas/data/sentiment/aclImdb_v1.tar.gz')
+ # dataset from http://ai.stanford.edu/~amaas/data/sentiment/
Review comment:
While it is good to include the full citation here, also add the information
on licensing and copyrights to the README or whatever docs people read which
tells them to download the data. The idea is that some of these licenses
actually have consequences. For example, we don't want to let commercial users
accidentally work with a non-commercial dataset. So, our goal is to make sure
that any time we inform users about a dataset, we also explain what legal
requirements come with that dataset as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
