Zha0q1 commented on a change in pull request #15132: Profiler API Enhancements
URL: https://github.com/apache/incubator-mxnet/pull/15132#discussion_r291423231
 
 

 ##########
 File path: python/mxnet/profiler.py
 ##########
 @@ -148,17 +148,32 @@ def dump_profile():
     dump(True)
 
 
-def dumps(reset=False):
+def dumps(reset=False, format='table', sort_by='avg', ascending=False):
     """Return a printable string of aggregate profile stats.
 
     Parameters
     ----------
     reset: boolean
-        Indicates whether to clean aggeregate statistical data collected up to 
this point
+        indicates whether to clean aggeregate statistical data collected up to 
this point
 
 Review comment:
   In profiler.py both lowercase and uppercase first letters are used. 
Lowercase first letters are used more so here I changed it to lowercase also

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to