access2rohit commented on a change in pull request #15210: [WIP] Custom
Operator Profiling Enhancement
URL: https://github.com/apache/incubator-mxnet/pull/15210#discussion_r292643814
##########
File path: src/operator/custom/custom-inl.h
##########
@@ -76,7 +77,8 @@ class CustomOperator {
bool training, const std::vector<NDArray>& arrs,
const std::vector<int>& tags,
const std::unordered_set<int>& output_tags,
- const std::vector<NDArray>& outputs) {
+ const std::vector<NDArray>& outputs,
+ const std::string op_type = "") {
Review comment:
is it possible that op_type can be empty ?(i.e. the user will not specify
any name for his/her custom operator ?) Since this method is only invoked for
custom operators I want to understand why do we need a default values unless
user can specify empty string as name for operator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
