Zha0q1 commented on a change in pull request #15210: [WIP] Custom Operator
Profiling Enhancement
URL: https://github.com/apache/incubator-mxnet/pull/15210#discussion_r292653208
##########
File path: src/operator/custom/custom-inl.h
##########
@@ -76,7 +77,8 @@ class CustomOperator {
bool training, const std::vector<NDArray>& arrs,
const std::vector<int>& tags,
const std::unordered_set<int>& output_tags,
- const std::vector<NDArray>& outputs) {
+ const std::vector<NDArray>& outputs,
+ const std::string op_type = "") {
Review comment:
op_type will not be empty. This function is called in three places:
custom.cc Forward(), custom.cc Backward(), and in src/c_api/c_api_function.cc.
We need to pass in op_type in the first two places. Having a default value
helps avoid creating a new api.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
