ThomasDelteil commented on a change in pull request #15230: Updating
SymbolBlock.imports to support different dtypes
URL: https://github.com/apache/incubator-mxnet/pull/15230#discussion_r293574298
##########
File path: tests/python/unittest/test_gluon.py
##########
@@ -2750,6 +2775,17 @@ def test_gluon_param_load():
net.cast('float16')
net.load_parameters('test_gluon_param_load.params', cast_dtype=True)
mx.nd.waitall()
+
+@with_seed()
+def test_gluon_param_load_dtype_source():
+ net = mx.gluon.nn.Dense(10, in_units=10)
+ net.initialize()
+ net.cast('float16')
Review comment:
I have added a test for the `ParameterDict` that should be sufficient since
it is the same mechanism as the network parameters: see
https://github.com/apache/incubator-mxnet/pull/15230/files#diff-962bd5bb7248659d7eb3be37ee8a4c6bR141
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services