apeforest commented on a change in pull request #15226: [Opperf] Make module/namespace of the operator parameterized URL: https://github.com/apache/incubator-mxnet/pull/15226#discussion_r293615865
########## File path: benchmark/opperf/rules/default_params.py ########## @@ -14,10 +14,16 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. +import sys + +# We will use all operators inside NDArray Module +# If you want to run benchmark for all operators in different namespace, +# for example mxnet.numpy.op, update here. All operators for benchmarks +# will be picked up from this module +MX_OP_MODULE = sys.modules["mxnet.ndarray.op"] Review comment: Can we make this configurable at runtime? It will be easier for CI team to automate the comparison between numpy operators and ndarray operators, right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
