sandeep-krishnamurthy commented on a change in pull request #15240: Fixing
duplication in operator profiling
URL: https://github.com/apache/incubator-mxnet/pull/15240#discussion_r295966280
##########
File path: src/profiler/profiler.h
##########
@@ -807,6 +810,13 @@ struct ProfileTask : public ProfileDuration {
ProfileObjectType type() const override { return kTask; }
+ /*!
+ * \brief Whether to add stat to AggregateStats
+ */
+ void enableAggregateStats(bool enabled) {
Review comment:
In the all the places this is True. Except in VTune task case.
Can we make it default parameter with default value True?
So in only VTune Task case, we set it to False. In other places, we don't
need to make changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
