anirudh2290 commented on a change in pull request #15118: Conversion from FP32 model to Mixed Precision model URL: https://github.com/apache/incubator-mxnet/pull/15118#discussion_r296057985
########## File path: src/nnvm/low_precision_pass.cc ########## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * Copyright (c) 2016 by Contributors + * \file low_precision_pass.cc + * \brief Return new graph with amp_cast and amp_multicast operators added wherever required + */ + +#include <nnvm/node.h> Review comment: The reason I asked "Why it is a bad practice?" because you called it not a good practice, and bad practice twice, with no justification for the same. The links that you provide talk nothing about "bad practice" or "not a good practice", only what they mean. I think you missed reading the article you sent. > There are a number of command-line options you can use to add additional directories to the search path. The most commonly-used option is -Idir, which causes dir to be searched after the current directory (for the quote form of the directive) and ahead of the standard system directories. You can specify multiple -I options on the command line, in which case the directories are searched in left-to-right order. > I tried to explain above without success, please refer to the compiler documentation: > If you need more clarification let's talk in person as seems the converstation is stuck. I don't like your tone. It was certainly not warranted here. Its an easy way to drive away new contributors. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
