haojin2 commented on a change in pull request #15277: [Numpy] Numpy argsort
URL: https://github.com/apache/incubator-mxnet/pull/15277#discussion_r296152237
##########
File path: tests/python/unittest/test_numpy_op.py
##########
@@ -775,6 +775,47 @@ def hybrid_forward(self, F, x):
mx_ret = net(a)
assert same(mx_ret.asnumpy(), np_ret)
+@with_seed()
[email protected]_np_shape
+def test_np_argsort():
+ @npx.use_np_shape
+ class TestArgsort(HybridBlock):
+ def __init__(self, axis=-1):
+ super(TestArgsort, self).__init__()
+ self._axis = axis
+
+ def hybrid_forward(self, F, a):
+ return F.np.argsort(a, self._axis)
+
+ shapes = [
+ (),
+ (1,),
+ (5,4),
+ (5,0,4),
+ (5,0,0),
+ (0,0,5),
+ (0,0,0),
+ (5,3,4)
+ ]
+ # test_shapes, remember to include zero-dim shape and zero-size shapes
+ for hybridize in [True, False]:
+ for shape in shapes:
+ for ax in list(range(len(shape))) + [-1, None]:
+ test_argsort = TestArgsort(ax)
+ if hybridize:
+ test_argsort.hybridize()
+
+ x = np.random.uniform(size=shape)
+ np_out = _np.argsort(x.asnumpy(), axis=ax)
+ mx_out = test_argsort(x)
+ assert mx_out.shape == np_out.shape
+ assert_almost_equal(mx_out.asnumpy(), np_out, rtol=1e-3,
atol=1e-5)
+
+ # Test imperative once again
+ mx_out = np.argsort(x, axis=ax)
+ np_out = _np.argsort(x.asnumpy(), axis=ax)
+ assert_almost_equal(mx_out.asnumpy(), np_out, rtol=1e-3,
atol=1e-5)
+
Review comment:
One more blank line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
