mli opened a new pull request #15347: [numpy] improve np.ones document
URL: https://github.com/apache/incubator-mxnet/pull/15347
 
 
   An example to improve the numpy.ones documents. No need to be merged. It 
makes the following changes:
   
   1. a customized function signature
   2. added back the order argument, so we can generate an error to say that 
order='F' is not supported, but codes with order='C' should still run
   3. copied all other docs from numpy, but need to check the codes in the 
example section
   4. used the 'notes' section to specify the difference between numpy.ones
   
   btw, I enabled the numpydoc ext in sphinx, please follow this guideline to 
write documents https://numpydoc.readthedocs.io/en/latest/ (I need to update 
our theme as well...)
   
   
![image](https://user-images.githubusercontent.com/421857/60070598-246b0900-96cc-11e9-9ada-5b83b5fc8a43.png)
   
   
![image](https://user-images.githubusercontent.com/421857/60070608-2b921700-96cc-11e9-9140-3e95211b79ca.png)
   
   @haojin2 @reminisce 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to