Chouffe commented on a change in pull request #15340: [Clojure] Add fastText
example
URL: https://github.com/apache/incubator-mxnet/pull/15340#discussion_r297295566
##########
File path:
contrib/clojure-package/examples/cnn-text-classification/src/cnn_text_classification/data_helper.clj
##########
@@ -190,6 +198,8 @@
vocab-embeddings (case pretrained-embedding
:glove (->> (load-glove (glove-file-path
embedding-size))
(build-vocab-embeddings vocab
embedding-size))
+ :fastText (->> (load-fasttext fasttext-file-path)
Review comment:
I would prefer a keyword like `:fast-text` or `:fasttext` instead of having
an uppercase character.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
