suyz526 commented on a change in pull request #15317: fix doc for the op sort()
and argsort()
URL: https://github.com/apache/incubator-mxnet/pull/15317#discussion_r297848854
##########
File path: src/operator/tensor/ordering_op.cc
##########
@@ -114,7 +114,7 @@ Examples::
[ 1., 3.]]
// flattens and then sorts
- sort(x) = [ 1., 1., 3., 4.]
+ sort(x, axis=None) = [ 1., 1., 3., 4.]
Review comment:
Sorry that I didn't get your point. What I did wrong in this PR?
If the argument `axis=None` is not given, this function will sort the array
alone the last axis. However, in the second example, we want the array to be
flattened and then sorted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
