anirudh2290 commented on issue #15375: Memory leak in Naive engine when 
profiling
URL: 
https://github.com/apache/incubator-mxnet/issues/15375#issuecomment-506535345
 
 
   I agree with you about fixing  the memory leak in the NaiveEngine and thanks 
for raising that. But i disagree about the need to refactor the release of 
operator memory in the threaded engine. This was a conscious design decision to 
use Object pool for operator objects which would be manually removed from and 
added back to the pool. This removal and addition was supposed to be managed by 
graph executors and other modules that push operators to the engine. If 
readability is really the issue that is very subjective and  I don't really see 
the benefit trump the cost here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to