wuxun-zhang commented on a change in pull request #15351: fix fp32 flatten issue URL: https://github.com/apache/incubator-mxnet/pull/15351#discussion_r298461383
########## File path: src/operator/nn/mkldnn/mkldnn_flatten.cc ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file mkldnn_flatten.cc + * \brief Implement flatten operator by using mkldnn reorder primitive + * \author Wuxun Zhang +*/ + +#if MXNET_USE_MKLDNN == 1 + +#include "mkldnn_reshape-inl.h" + +namespace mxnet { +namespace op { + +class MKLDNNFlattenFwd : public MKLDNNReshapeFwd { + public: + explicit MKLDNNFlattenFwd(const OpReqType &req, + const NDArray &input, + const NDArray &output) + : MKLDNNReshapeFwd(req, input, output) {} +}; + +static MKLDNNFlattenFwd &GetFlattenForward(const OpReqType &req, Review comment: Seems cannot combine these two functions into one. Because `reshape` op have a parameter `ReshapeParam` while `flatten` op don't, so when we try to create `key`, for `reshape` we use `MKLDNNReshapeSignature key(ReshapeParam)`, but for `flatten` we use `OpSignature key`. So, this function should be designed differently. Also, `expand_dims` op also have a parameter, and can reuse this function with `reshape` op. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
