pengzhao-intel commented on a change in pull request #15167: [WIP] Pointwise 
fusion for GPU
URL: https://github.com/apache/incubator-mxnet/pull/15167#discussion_r298802432
 
 

 ##########
 File path: docs/faq/env_var.md
 ##########
 @@ -309,6 +309,17 @@ If ctypes is used, it must be 
`mxnet._ctypes.ndarray.NDArrayBase`.
     with float32.
   - Model accuracies do not necessarily improve with this environment variable 
turned on.
 
+* MXNET_USE_FUSION
 
 Review comment:
   It makes sense. 
   
   @aaronmarkham  do you have any suggestion?
   Simple background, @ptrendx please correct me if anything is not correct.
   
   Currently, two environments deliver similar functionality where 
`MXNET_SUBGRAPH_BACKEND=MKLDNN` is for CPU fusion and `MXNET_USE_FUSION` is for 
GPU.
   I suggest aligning to `MXNET_SUBGRAPH_BACKEN={MKLDNN, CUDNN}` because this 
is already widely used for operator fusion but the name of `SUBGRAPH` doesn't 
match with technical details inside GPU implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to