reminisce commented on issue #13143: [MXNET-1206] Support NDArray indexing with None and Ellipsis URL: https://github.com/apache/incubator-mxnet/pull/13143#issuecomment-507143669 Thanks for addressing the cr comments. Since the logic of integer indexing and first-axis contiguous slicing have been organized into a more general case handling flow, could you verify there is no performance regression in the situation where an output ndarray sharing the memory with the input ndarray? This kind of indexing is used a lot in Gluon dataset loaders and is critical to the training performance.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
