sandeep-krishnamurthy commented on a change in pull request #15245: FP16
Support for C Predict API
URL: https://github.com/apache/incubator-mxnet/pull/15245#discussion_r299709638
##########
File path: src/c_api/c_predict_api.cc
##########
@@ -210,19 +249,31 @@ int _CreatePartialOut(const char* symbol_json_str,
std::vector<NDArray> arg_arrays, aux_arrays;
for (size_t i = 0; i < arg_shapes.size(); ++i) {
- NDArray nd = NDArray(arg_shapes[i], ctx);
+ NDArray nd;
+ if (result_arg_types[i] != -1) {
+ nd = NDArray(arg_shapes[i], ctx, false, result_arg_types[i]);
+ } else {
+ nd = NDArray(arg_shapes[i], ctx);
+ }
if (arg_params.count(arg_names[i]) != 0) {
CopyFromTo(arg_params[arg_names[i]], &nd);
}
arg_arrays.push_back(nd);
}
+
for (size_t i = 0; i < aux_shapes.size(); ++i) {
- NDArray nd = NDArray(aux_shapes[i], ctx);
+ NDArray nd;
+ if (result_aux_types[i] != -1) {
Review comment:
Since we are doing such check on types throughout, can we otherwise think of
a setting a default DType for all params if users are not providing arg types
params? So we could get rid of all these checks and always types will be
available. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
