yugoren commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl URL: https://github.com/apache/incubator-mxnet/pull/15424#issuecomment-509742449 > @yugoren Please find the definition of `MSHADOW_USE_MKL` at https://github.com/dmlc/mshadow/blob/master/mshadow/base.h#L88 and https://github.com/dmlc/mshadow/blob/master/make/mshadow.mk#L101 Thanks, that clears out how MKL is enabled by default in `mshadow`! Also, going back to the initial concern @TaoLv had about the comment we added: even if we pass `USE_BLAS=mkl` to `make`, the lines that @nuslq pointed out overrides the variable ``` UNAME_S := $(shell uname -s) ifeq ($(UNAME_S), Darwin) USE_BLAS = apple else USE_BLAS = atlas endif ``` That's why we felt it would be informative for the user to know exactly where to set the flag. Maybe we can change it to the following ``` UNAME_S := $(shell uname -s) ifeq ($(UNAME_S), Darwin) USE_BLAS ?= apple else USE_BLAS ?= atlas endif ``` @larroy What do you think? Another question: is `MSHADOW_USE_MKL` enabled in `mxnet` build when `mshadow/base.h` is included in the files (maybe cascaded)? Could you also clarify why the flag is clearly set to `1` in `cmake` while set only through including a header file in `make`? This was one of the reason it was hard for me to track down how the flag is enabled in `mxnet` side and I was considering adding it into compiler definitions, probably in a separate PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
