ptrendx commented on issue #15285: Graph dumper
URL: https://github.com/apache/incubator-mxnet/pull/15285#issuecomment-509790305
 
 
   @larroy There is no need to get so defensive about this, I (and I assume 
others as well) just want to make your contribution better as a result of the 
review process.
   Going back to this graph class - the problem I have with introducing it is 
that I do not see any value added by it, as (I think) all of the functionality 
needed is already there in nnvm::Graph and IndexedGraph, while it makes the 
codebase less readable and maintainable. Do you have an example of 
functionality that is required but is not covered by the existing classes?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to