zixuanweeei commented on a change in pull request #15497: Independent gradients
requests check with respect to weights and bias of convolution
URL: https://github.com/apache/incubator-mxnet/pull/15497#discussion_r302333454
##########
File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
##########
@@ -662,21 +662,21 @@ void MKLDNNConvolutionBackward(const nnvm::NodeAttrs&
attrs, const OpContext &ct
in_grad[conv::kWeight],
convBwdWeight.bwdWeights_pd.diff_weights_primitive_desc(),
req[conv::kWeight]);
- mkldnn_output_t in_grad_bias;
- if (param.no_bias) {
- convBwdWeight.SetWeightNewMem(*data_mem, *out_grad_mem,
- *in_grad_weight.second);
- MKLDNNStream::Get()->RegisterPrim(convBwdWeight.GetBwdWeights());
- } else {
- in_grad_bias = CreateMKLDNNMem(
+
+ if (!param.no_bias && req[conv::kBias]) {
+ auto in_grad_bias = CreateMKLDNNMem(
in_grad[conv::kBias],
convBwdWeight.bwdWeights_pd.diff_bias_primitive_desc(),
req[conv::kBias]);
convBwdWeight.SetWeightNewMem(*data_mem, *out_grad_mem,
- *in_grad_weight.second, *in_grad_bias.second);
+ *in_grad_weight.second, *in_grad_bias.second);
MKLDNNStream::Get()->RegisterPrim(convBwdWeight.GetBwdWeights());
CommitOutput(in_grad[conv::kBias], in_grad_bias);
+ } else {
Review comment:
Sure. I see. There is unnecessary primitive registration without the check
enabled. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
