ChaiBapchya commented on a change in pull request #15538: some minor typos/clarifications URL: https://github.com/apache/incubator-mxnet/pull/15538#discussion_r303533233
########## File path: scala-package/README.md ########## @@ -156,21 +156,21 @@ mvn -Dsuites=org.apache.mxnet.NDArraySuite integration-test ``` If everything goes well, you will find jars for `assembly`, `core` and `example` modules. -Also it produces the native library in `native/target`, which you can use to cooperate with the `core` module. +Also it produces the native library in `native/target`, which you can use in conjunction with the `core` module. Deploy to repository -------------------- -By default, `maven deploy` will deploy artifacts to local file system, you can file then in: ``scala-package/deploy/target/repo`` folder. +By default, `maven deploy` will deploy artifacts to local file system, you can find them in the ``scala-package/deploy/target/repo`` folder. -For nightly build in CI, a snapshot build will be uploaded to apache repository with follow command: +For nightly builds (typically done by CI), a snapshot build will be uploaded to an apache snapshot repository with the following command: ```bash cd scala-package mvn deploy -Pnightly ``` -Use following command to deploy release build (push artifacts to apache staging repository): +Use the following command when performing a release (pushes artifacts to an apache staging repository): Review comment: Previous statement was good enough, I guess (in terms of comprehensibility) . ```suggestion Use the following command when performing a release (pushes artifacts to an Apache staging repository): ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
