marcoabreu commented on a change in pull request #15621: [WIP] MKL-DNN LBR-GRU
Inference Integration (FP32 LBR-GRU)
URL: https://github.com/apache/incubator-mxnet/pull/15621#discussion_r305826471
##########
File path: src/operator/nn/mkldnn/mkldnn_rnn_impl.h
##########
@@ -118,7 +151,7 @@ static size_t GetMKLDNNRNNCacheMemorySize(int L,
break;
case rnn_enum::kGru:
size = 2 * (D * (I + H) * 3 * H + (L - 1) * D * (D * H + H) * 3 * H +
- L * D * 2 * N * H) + T * N * D * H + L * 2 * D * 3 * H + (L + 2)
* D * 2 * N * H +
+ L * D * 2 * N * H) + T * N * D * H + L * 2 * D * 4 * H + (L + 2)
* D * 2 * N * H +
Review comment:
Nit: I know it's out of the scope of this PR, but could we rename the
variables to something more self-explanatory?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
