roywei edited a comment on issue #15640: Performance regression for MXNet 1.5.0
URL: 
https://github.com/apache/incubator-mxnet/issues/15640#issuecomment-514344026
 
 
   Hi @QueensGambit, thanks for your detailed reply. Very cool project!
   
   There was a lengthy discussion about operator performance regression here: 
https://github.com/apache/incubator-mxnet/issues/15429#issuecomment-508831150
   It's still open as we need more comprehensive method to evaluate operator 
performance, and there could be regressions we didn't detect.
   
   Summary is:
   1. The profiler code changed between 1.4.1 and 1.5.0, so it's not an apple 
to apple comparison. (same untouched operators became slow due to profiler 
change)
   2. Using `time` module, we didn't see significant regression on `batchnorm` 
and `broadcast add`, 1-3% at most and givent the variance between runs, we 
decided to go with the release.  Relu activation slow is expected for 
correctness.
   3. We can look into `convlution` you mentioned.
   
   Also if the `cp` `nodes` `depths` values are different, does it mean the 
time will be different?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to