zoeygxy commented on issue #13143: [MXNET-1206] Support NDArray indexing with None and Ellipsis URL: https://github.com/apache/incubator-mxnet/pull/13143#issuecomment-515378060 Hi, thank you for your work! I am from MXNet team and I'm currently working on indexing of mxnet.numpy.ndarray, the child class of NDArray class. The numpy.ndarray indexing is currently based on your version of ``ndarray.py``, and I have thus made some changes to this file on [my branch](https://github.com/zoeygxy/incubator-mxnet/commits/numpy_indexing): * Added support of ``None`` in NDArray advanced slicing, so that all the test cases in your ``test_ndarray.py`` are passed. Example of supported case: ``` index = (slice(None), slice(3, 5), None, None, [2, 3], [3, 4]) ``` * Wrapped some operators as NDArray class methods so that my implementation can take advantage of your exisitng code by inheritance. You can still make changes when you are back and I will adapt my code to them. Thanks for your contribution!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
