kshitij12345 commented on a change in pull request #15331: [fix] missing input
log higher order.
URL: https://github.com/apache/incubator-mxnet/pull/15331#discussion_r307774348
##########
File path: src/operator/tensor/elemwise_unary_op_basic.cc
##########
@@ -1117,15 +1117,15 @@
MXNET_OPERATOR_REGISTER_BINARY_WITH_SPARSE_CPU_DR(_backward_log10,
unary_bwd<mshadow_op::log10_grad>)
.set_attr<nnvm::FGradient>("FGradient",
[](const nnvm::NodePtr& n, const std::vector<nnvm::NodeEntry>& ograds) {
- // ograds[0]: dL/dxgrad
+ // ograds[0]: dL/dygrad
Review comment:
Oh. I get it now. If I understand it correctly then, crudely `ograds[0]` is
how much does the `x_grad` affect the `L` and then we compute how does `x_grad`
change with `x`. Makes sense now.
Thank you very much. Will reflect it in this and other PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
