ZhennanQin commented on a change in pull request #15678: [MXNET-1418]Add
contrib op into cpp package
URL: https://github.com/apache/incubator-mxnet/pull/15678#discussion_r308052505
##########
File path: cpp-package/scripts/OpWrapperGenerator.py
##########
@@ -88,8 +88,10 @@ class Arg:
'caffe-layer-parameter':'::caffe::LayerParameter',\
'NDArray-or-Symbol[]':'const std::vector<Symbol>&',\
'float':'mx_float',\
+ 'float or None':'mx_float',\
Review comment:
Why not `'float or None':'dmlc::optional<float>',\`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
