sandeep-krishnamurthy commented on a change in pull request #15715: Improve
diagnose.py to display environment variables
URL: https://github.com/apache/incubator-mxnet/pull/15715#discussion_r309949704
##########
File path: tools/diagnose.py
##########
@@ -171,6 +161,31 @@ def check_network(args):
for name, url in URLS.items():
test_connection(name, url, args.timeout)
+
+def check_environment():
Review comment:
I was thinking like AWS credentials or some sensitive details can be part of
ENV variables.etc. Will be also environment variables. We cannot list
everything and depend on user to remove it IMO.
Do we have a registry for all environment variables?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
