TaoLv commented on a change in pull request #15621: MKL-DNN LBR-GRU Inference
Integration (FP32 LBR-GRU)
URL: https://github.com/apache/incubator-mxnet/pull/15621#discussion_r309960136
##########
File path: src/operator/nn/mkldnn/mkldnn_rnn_impl.h
##########
@@ -73,64 +93,69 @@ static void ConcatData(mkldnn::memory::format src_format,
mkldnn::memory::dims dst_cds,
mkldnn::memory::data_type mkldnn_dtype,
int concat_dimension,
- std::vector<void*> srcs_data,
- const mkldnn::memory &dst) {
+ const std::vector<void*> &srcs_data,
+ const mkldnn::memory &dst,
+ std::vector<mkldnn::memory> *tmp_src_mems) {
auto cpu_engine = CpuEngine::Get()->get_engine();
std::vector<mkldnn::memory::primitive_desc> srcs_pd;
- std::vector<mkldnn::memory> srcs;
+ bool initialized = tmp_src_mems->size() > 0;
Review comment:
const bool initialized?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
