ChaiBapchya commented on a change in pull request #15528: Add AMP Conversion
support for BucketingModule
URL: https://github.com/apache/incubator-mxnet/pull/15528#discussion_r309975262
##########
File path: tests/python/train/test_bucketing.py
##########
@@ -101,9 +108,14 @@ def sym_gen(seq_len):
num_epoch=num_epochs,
batch_end_callback=mx.callback.Speedometer(batch_size, 50))
logging.info('Finished fit...')
+ return model
+
+
+def test_bucket_module():
# This test forecasts random sequence of words to check bucketing.
# We cannot guarantee the accuracy of such an impossible task, and
comments out the following line.
Review comment:
not related to your PR. But what is the purpose of this line? Can it be made
clearer?
Is it just a Note? then "comments out the following line" is not even needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
