eric-haibin-lin commented on a change in pull request #15559: [MXNET-1294] Add
PushPull API
URL: https://github.com/apache/incubator-mxnet/pull/15559#discussion_r306066627
##########
File path: include/mxnet/kvstore.h
##########
@@ -198,6 +198,23 @@ class KVStore {
const std::vector<NDArray*>& values,
int priority = 0, bool ignore_sparse = true) = 0;
+ /**
+ * TODO: Comment
+ */
+ virtual void PushPull(const std::vector<int>& vkeys,
+ const std::vector<int>& okeys,
+ const std::vector<NDArray>& values,
+ const std::vector<NDArray*>& outs,
+ int priority = 0, bool ignore_sparse = true) = 0;
+
+ /**
+ * TODO: Comment
+ */
+ virtual void PushPull(const std::vector<std::string>& str_vkeys,
+ const std::vector<std::string>& str_okeys,
+ const std::vector<NDArray>& values,
+ const std::vector<NDArray*>& outs,
+ int priority = 0, bool ignore_sparse = true) = 0;
Review comment:
remove the ignore_sparse flag
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
