ChaiBapchya opened a new issue #15735: Arg name inconsistencies URL: https://github.com/apache/incubator-mxnet/issues/15735 Operators like `concat`, `Elementwise_sum`, `add_n`, `squeeze`, `stack` etc have one of their parameters as `*args` (variable argument) and specifically the arg_type is `NDArray-or-Symbol[]` (notice it is a list of NDArray or Symbol) However, the arg_name for such arg_type is different for different functions `'arg_name': 'args', 'arg_type': 'NDArray-or-Symbol[]'` 1. khatri_rao 'khatri_rao': {'has_backward': False, 'nd_op_handle': <function khatri_rao at 0x122548ae8>, 'params': {'narg': 1, 'arg_names': ['args'], 'arg_types': ['NDArray-or-Symbol[]']}} 2. Elementwise_sum 'ElementWiseSum': {'has_backward': False, 'nd_op_handle': <function ElementWiseSum at 0x122455950>, 'params': {'narg': 1, 'arg_names': ['args'], 'arg_types': ['NDArray-or-Symbol[]']}} 3. add_n 'add_n': {'has_backward': False, 'nd_op_handle': <function add_n at 0x122533488>, 'params': {'narg': 1, 'arg_names': ['args'], 'arg_types': ['NDArray-or-Symbol[]']}} `'arg_name': 'data', 'arg_type': 'NDArray-or-Symbol[]'` while for other operators `squeeze`, `concat`, `stack`, etc Note - 3 ops that have arg_name as `args` have just 1 argument Rest ops that have arg_name as `data` have multiple arguments Is this a case of inconsistency? Should they all be referred as `data` instead of generic `args`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
