reminisce commented on issue #13143: [MXNET-1206] Support NDArray indexing with None and Ellipsis URL: https://github.com/apache/incubator-mxnet/pull/13143#issuecomment-517902835 @kohr-h I rebased your branch with master. After the CI passes, I will merge the PR. I also commented out the test cases where `None` is used in advanced indices since it has not been supported yet. @zoeygxy has implemented this in [her branch](https://github.com/zoeygxy/incubator-mxnet/blob/numpy_indexing/python/mxnet/ndarray/ndarray.py) and will PR the change together with indexing support for `mxnet.numpy.ndarray`. In summary, there are two action items (by @zoeygxy) after this PR is merged: 1. Fix indexing performance regression for outputs being views. 2. Implement `None` support for advanced indices. Please let us know if you have other concerns or suggestions. Thanks again for your contribution.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
