samskalicky edited a comment on issue #15489: Dynamic Library Loading Support
URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-517942331
 
 
   @leleamol Can you please review again to see if the implementation of the 
dlclose matches what you were thinking?
   
   @anirudh2290 Thanks for the help with the engine destructor info, can you 
take a look at the changes to the engines:
   
https://github.com/apache/incubator-mxnet/blob/134cc37d6b306514fde1a405d3b87cc946a56bd1/src/engine/naive_engine.cc#L88-L91
   
https://github.com/apache/incubator-mxnet/blob/134cc37d6b306514fde1a405d3b87cc946a56bd1/src/engine/threaded_engine.h#L335-L338

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to