eric-haibin-lin commented on a change in pull request #15657: Eliminate common
expressions
URL: https://github.com/apache/incubator-mxnet/pull/15657#discussion_r310371687
##########
File path: include/mxnet/op_attr_types.h
##########
@@ -208,6 +208,17 @@ using FCreateOpState = std::function<OpStatePtr (const
NodeAttrs& attrs,
Context ctx,
const mxnet::ShapeVector&
in_shape,
const std::vector<int>&
in_type)>;
+
+/*!
+ * \brief Whether the operator always produces the same
+ * output given the same input.
+ * This enables certain optimizations
+ * like common expression elimination.
+ *
+ * \note Register under "FHasDeterministicOutput"
+ */
+using FHasDeterministicOutput = bool;
Review comment:
This is a per-op attribute, right? Are we supposed to mark relevant
operators with the right value for this attribute in this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
