mseth10 commented on a change in pull request #15760: build sample library in CI
URL: https://github.com/apache/incubator-mxnet/pull/15760#discussion_r310849601
##########
File path: tests/python/unittest/test_library_loading.py
##########
@@ -33,6 +33,7 @@ def test_library_loading():
elif (os.name=='nt'):
lib = 'mylib.dll'
- fname =
mx.test_utils.download('https://mxnet-demo-models.s3.amazonaws.com/lib_binary/'+lib)
- fname = os.path.abspath(fname)
+ # fname =
mx.test_utils.download('https://mxnet-demo-models.s3.amazonaws.com/lib_binary/'+lib)
+ # fname = os.path.abspath(fname)
+ fname = 'Somewhere/In/The/CI'
Review comment:
@marcoabreu what should we change this to to get the path to the library
libsample_lib.so/.dll?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
