DickJC123 commented on issue #15688: Fix backward_clip num inputs and type of clip params URL: https://github.com/apache/incubator-mxnet/pull/15688#issuecomment-518835813 My thought with the comment about a_min and a_max casting was to describe precisely the behavior of the op. While my first suggestion might be too detailed, I still think it important to alert the user to the rounding of the limits, in case they have some home-grown bucketing of the clipped outputs. How about: ``` The actual limits used by clip are the provided a_min and a_max values rounded to the nearest x.dtype. ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
