KellenSunderland commented on a change in pull request #15399: Add unit tests
for TensorRT integration and fix some bugs
URL: https://github.com/apache/incubator-mxnet/pull/15399#discussion_r311301656
##########
File path: src/operator/subgraph/tensorrt/tensorrt-inl.h
##########
@@ -180,6 +253,17 @@ class TensorrtProperty : public SubgraphProperty {
n->attrs.name = "TensorRT" + std::to_string(subgraph_id);
n->attrs.op = Op::Get("_TensorRT");
CHECK(n->attrs.op);
+ // prevent using Gamma value if using fix_gamma on BatchNorm
+ DFSVisit(new_sym.outputs, [&n](const nnvm::NodePtr& node) {
+ if (node->op() == Op::Get("BatchNorm")) {
Review comment:
I think this one should be handled upstream. Have a look at
https://github.com/apache/incubator-mxnet/commit/6b22aa455e562db0e2744e94dc6a583191081b05
and let us know if you'd rather use this fix or if ours looks ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
